----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92958 -----------------------------------------------------------
include/mesos/mesos.proto (line 397) <https://reviews.apache.org/r/36663/#comment147227> Can you please add these deprecation warnings to 0.24.0 CHANGELOG? ``` Release Notes - Mesos - Version 0.24.0 (WIP) * Deprecations <blah> ``` src/common/protobuf_utils.cpp (line 194) <https://reviews.apache.org/r/36663/#comment147229> s/remove/Remove/ src/master/master.cpp (line 320) <https://reviews.apache.org/r/36663/#comment147230> s/the/The/ src/tests/master_tests.cpp (line 995) <https://reviews.apache.org/r/36663/#comment147246> Make this a MasterZooKeeperTest so that we can use zookeeper detector here and test Master::Master() changes! TEST_F(MasterZooKeeperTest, MasterInfoAddress) you'll want to move this to #2163 src/tests/master_tests.cpp (line 1023) <https://reviews.apache.org/r/36663/#comment147233> new line. src/tests/master_tests.cpp (line 1024) <https://reviews.apache.org/r/36663/#comment147234> period at the end. - Vinod Kone On July 24, 2015, 12:17 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36663/ > ----------------------------------------------------------- > > (Updated July 24, 2015, 12:17 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-2736 > https://issues.apache.org/jira/browse/MESOS-2736 > > > Repository: mesos > > > Description > ------- > > Added address field to MasterInfo > > As part of the new HTTP API and the need to > provide a better interface for clients that > do not integrate libmesos, we provide the IP > address of the Leader Master in the information > that gets serialized (in JSON) to ZooKeeper. > > This will eventually supersede the `ip`, `port` > and `hostname` fields that are currently in > MasterInfo an which cannot fully support IPv6 > addresses. > > Jira: MESOS-2736 > > Review: https://reviews.apache.org/r/36663 > > > Diffs > ----- > > include/mesos/mesos.proto e015c81d5052214ef8207642e23b3892a6123c9a > src/common/protobuf_utils.cpp e0f82b53f5e106bbf4e21d6ac946df0fae821882 > src/master/master.cpp bab04feaf238e51c4d50feb1d3a9c0735ec68fec > src/tests/master_contender_detector_tests.cpp > d7a3b46b2e437818631064ae34317e49c9aa3748 > src/tests/master_tests.cpp 826f276317da2507cdf99b2f2e21a147444469d8 > > Diff: https://reviews.apache.org/r/36663/diff/ > > > Testing > ------- > > make check > (also tested via [zk-mesos](https://github.com/massenz/zk-mesos) that the > information serialized to ZK is readable and as expected). > > Also ran 2x 0.23 master builds against a 0.24 one with this patch applied; > getting both versions in turn to be Leader, and also ran a 0.23 Slave with a > 0.24 Leader, and they all recognized each other. > > > Thanks, > > Marco Massenzio > >
