----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128/#review92983 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp (line 774) <https://reviews.apache.org/r/34128/#comment147260> Why the extra variable here? This part of the code shouldn't need to change IIUC. 3rdparty/libprocess/src/process.cpp (lines 819 - 835) <https://reviews.apache.org/r/34128/#comment147259> Let's be more specific in the naming here, how about LIBPROCESS_ADVERTISE_IP and LIBPROCESS_ADVERTISE_PORT. You use the verb 'advertise' in your description above, which is much more self-explanatory than PUBLIC. Also, I'm not sure why the 'os::getenv' change didn't make it in here but we should use that throught here as well (and 'numify' instead of 'atoi'), but feel free to follow up in a subsequent patch. Thanks! - Benjamin Hindman On May 18, 2015, 10:08 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34128/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 10:08 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-809 > https://issues.apache.org/jira/browse/MESOS-809 > > > Repository: mesos > > > Description > ------- > > Expose environment variables LIBPROCESS_PUBLIC_IP and LIBPROCESS_PUBLIC_PORT > as the IP and > port which libprocess would advertise (if set). If not set, it defaults to > the IP and port on which it binded to. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > e3de3cd6b536aaaf59784360aed546512dd04dc9 > > Diff: https://reviews.apache.org/r/34128/diff/ > > > Testing > ------- > > Testing: > make test > > > Thanks, > > Anindya Sinha > >
