----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93141 -----------------------------------------------------------
thanks for doing this! (this may also fix a long-standing issue of mine: https://issues.apache.org/jira/browse/MESOS-2337 - could you please take a look?) Only a few minor nits about formatting and stuff, then I think this is good. We'll need to find a committer to push this. Did you test it? on which platforms? src/Makefile.am (lines 933 - 940) <https://reviews.apache.org/r/36819/#comment147401> please don't just comment out a bunch of lines of code without explaining why you do this - is there a TODO there? why are you commenting out, instead of removing them? Also, isn't this patch about exactly that TODO(benh)? shouldn't you remove it? or comment? src/Makefile.am (lines 1192 - 1196) <https://reviews.apache.org/r/36819/#comment147402> not sure if it's an RB artifact, or your tab spacings are all off: can you please verify the continuation \ are all lined up? not just here, too, but everywhere src/cli/python/mesos/__init__.py (line 20) <https://reviews.apache.org/r/36819/#comment147403> s/utils/utilities src/python/cli/src/mesos/__init__.py (line 1) <https://reviews.apache.org/r/36819/#comment147406> good job at adding the reference, but also please add a few lines to explain why this is being done here (in brief, then you have the URL ref for those who want to learn the gory details) I've been working on Python for the past five years, and yet these lines scare me :) - Marco Massenzio On July 26, 2015, 5:24 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36819/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 5:24 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-3149 > https://issues.apache.org/jira/browse/MESOS-3149 > > > Repository: mesos > > > Description > ------- > > Use setup.py in python cli package. > > > Diffs > ----- > > Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e > bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95 > configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500 > src/Makefile.am a7104bb642339c2fe8a466983300d4c62dc2b344 > src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef > src/cli/python/mesos/cli.py > src/cli/python/mesos/futures.py > src/cli/python/mesos/http.py > src/python/cli/src/mesos/__init__.py PRE-CREATION > > Diff: https://reviews.apache.org/r/36819/diff/ > > > Testing > ------- > > make check > > > Thanks, > > haosdent huang > >
