----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/#review93055 -----------------------------------------------------------
Ship it! src/tests/containerizer_tests.cpp (line 311) <https://reviews.apache.org/r/36755/#comment147322> s/e/v/ at least and 'variable' even better! - Benjamin Hindman On July 26, 2015, 6:49 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36755/ > ----------------------------------------------------------- > > (Updated July 26, 2015, 6:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Jie Yu. > > > Bugs: MESOS-3133 > https://issues.apache.org/jira/browse/MESOS-3133 > > > Repository: mesos > > > Description > ------- > > Append the environment variables returned by Isolator::prepare() to the > list of environment variables being passed to the executor. Added a test > to verify that the executor is launched with the said environment > variables. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > 11eedf30674b326ea3e1f6f71d27f9eb54126368 > src/tests/containerizer/containerizer_tests.cpp > a44b6e887c37e55213db068a95ab3e73a033e1ea > > Diff: https://reviews.apache.org/r/36755/diff/ > > > Testing > ------- > > make check with an added test. > > > Thanks, > > Kapil Arya > >
