----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review93272 -----------------------------------------------------------
docs/fetcher-cache-internals.md (line 107) <https://reviews.apache.org/r/36773/#comment147646> removes the *most* recently used first src/slave/containerizer/fetcher.cpp (line 889) <https://reviews.apache.org/r/36773/#comment147647> Refresh the cache entry by moving it to the back... src/slave/containerizer/fetcher.cpp (line 987) <https://reviews.apache.org/r/36773/#comment147648> Should we put a comment above the function saying that it is LRU based? src/slave/containerizer/fetcher.cpp (line 990) <https://reviews.apache.org/r/36773/#comment147649> s/result/victims src/tests/fetcher_cache_tests.cpp (line 1450) <https://reviews.apache.org/r/36773/#comment147650> Is this an expectation or assertion? IMO the test shouldn't continue if this fails. (I see that it is the same pattern in other tests, still doens't mean it is correct ;-) ) src/tests/fetcher_cache_tests.cpp (line 1463) <https://reviews.apache.org/r/36773/#comment147651> Just as a comment: I find cacheSize() very unintuive name for this function, would have expected something along cacheFiles().size() or numberEntries() - Joerg Schad On July 27, 2015, 3:38 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36773/ > ----------------------------------------------------------- > > (Updated July 27, 2015, 3:38 p.m.) > > > Review request for mesos, Bernd Mathiske and Joerg Schad. > > > Bugs: MESOS-3112 > https://issues.apache.org/jira/browse/MESOS-3112 > > > Repository: mesos > > > Description > ------- > > A linked list is used to keep cache entries in LRU-to-MRU order. Each time an > existing cache entry is requested, it is moved to the back of the list. > During cache eviction entries are removed from the front of the list until > enough cache space can be freed. > > > Diffs > ----- > > docs/fetcher-cache-internals.md 327cbc3074bcc110e1250e2151dd5401ccaadb4b > src/slave/containerizer/fetcher.hpp > 17225072ba5c1c9a7209f2923bcf562fcb76201f > src/slave/containerizer/fetcher.cpp > e030deabd5e749100cbccabb256dbd4af8b2fe58 > src/tests/fetcher_cache_tests.cpp bd9c406a532a85fa95a5e9cfa6003f4893191c57 > > Diff: https://reviews.apache.org/r/36773/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
