-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36900/
-----------------------------------------------------------
(Updated July 29, 2015, 5:27 a.m.)
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Vinod Kone.
Changes
-------
Anand's comments
Bugs: MESOS-3135
https://issues.apache.org/jira/browse/MESOS-3135
Repository: mesos
Description
-------
As part of the support for non-libmesos linked client to
interact with the HTTP API, we also provide the Master information
stored in ZooKeeper in a way that is deserializable also for
clients that do not necessarily know how to decode a MasterInfo
protocol buffer.
This patch publishes the data in JSON format and has been tested,
summarily, with 2 masters running this patch alongside a 0.23 Master and
one each of 0.24 and 0.23 Agent nodes.
Please note this patch does not require specific unit testing, as the
functionality
is already widely tested in existing `ZooKeeper*` tests, as well as
`MasterDetector*` ones.
Diffs (updated)
-----
src/master/contender.cpp 2af70c7d1acf274db40cae1641cd305249a471ec
Diff: https://reviews.apache.org/r/36900/diff/
Testing
-------
make check
also ran: 3x Masters (2x 0.24 + 1x 0.23) / 2x Slaves (1x 0.23 + 1x 0.24)
the 0.24's were running this patch.
Also verified in ZK that the data was correct JSON:
```
{
"address":{
"hostname":"10.0.77.243",
"ip":"10.0.77.243",
"port":5050
},
"hostname":"10.0.77.243",
"id":"20150728-165830-4081909770-5050-64014",
"ip":4081909770,
"pid":"master@10.0.77.243:5050",
"port":5050,
"version":"0.24.0"
}
```
Not sure why Reviewbot failed, but the tests all passed:
```
[----------] Global test environment tear-down
[==========] 684 tests from 97 test cases ran. (274274 ms total)
[ PASSED ] 684 tests.
YOU HAVE 12 DISABLED TESTS
```
the error seems to be with files left in `src/credentials` and
`src/master/replicated_log`:
```
ERROR: files left in build directory after distclean:
./src/credentials
./src/master/replicated_log/CURRENT
./src/master/replicated_log/LOG
./src/master/replicated_log/MANIFEST-000006
./src/master/replicated_log/000011.sst
./src/master/replicated_log/LOCK
./src/master/replicated_log/000009.log
./src/master/replicated_log/LOG.old
make[1]: *** [distcleancheck] Error 1
```
Am I missing something here?
Thanks,
Marco Massenzio
