> On July 28, 2015, 8:05 a.m., Adam B wrote: > > src/health-check/main.cpp, line 243 > > <https://reviews.apache.org/r/36816/diff/1/?file=1021956#file1021956line243> > > > > Maybe we should add `http.protocol()` in case the user wants https? Or > > `http.ssl` like BenH suggested. Would we ever want anything besides > > http/https? > > We can always add that in a later patch, so feel free to ignore for now.
Could add https now. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review93254 ----------------------------------------------------------- On July 25, 2015, 6:57 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > ----------------------------------------------------------- > > (Updated July 25, 2015, 6:57 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Support HTTP checks in Mesos health check program > > > Diffs > ----- > > include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba > src/health-check/main.cpp 97b25716335ec5719c1100bd73d06b7fc98036c9 > src/tests/health_check_tests.cpp 157a56aa06677d8b7a2cef53b29ed05cb4b5d8ea > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > ------- > > * Add a new unit test: HealthCheckTest.HealthyTaskThroughHttp > make check > > > Thanks, > > haosdent huang > >