----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94059 -----------------------------------------------------------
include/mesos/authorizer/authorizer.hpp (line 83) <https://reviews.apache.org/r/36048/#comment148560> "If the request satifies the ACLs, it returns true." There's another one below. include/mesos/authorizer/authorizer.hpp (line 91) <https://reviews.apache.org/r/36048/#comment148561> s/the ACL/the ACLs to be consistent with the paragraph above. - Jan Schlicht On Aug. 4, 2015, 4:13 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36048/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 4:13 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Bernd Mathiske, Kapil > Arya, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-2946 > https://issues.apache.org/jira/browse/MESOS-2946 > > > Repository: mesos > > > Description > ------- > > Splits and updates the original declaration of the `Authorizer` into its > interface and a default implementation, the `LocalAuthorizer`. > > Following the pattern of the modularized `Authenticator`, it generates a > default constructor which is required when writing a `TYPED_TEST` in > a follow up patch. Additionally, an initialize method has been added, needed > for passing in the current ACL definitions as provided via > flags. > > Other changes are just updates to allow for compilation. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp PRE-CREATION > include/mesos/authorizer/authorizer.proto PRE-CREATION > include/mesos/mesos.proto a6748d1cd82238f005c6a49c70d22d095462f1ba > include/mesos/type_utils.hpp 86b37ca1f63e4687af4e86731dceeb1c9c219c5e > src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec > src/authorizer/authorizer.hpp c039d9412780aa199db169b31991bf9f45b07d0f > src/authorizer/authorizer.cpp 21e97e315478a4ca9442af83732665f85eb2f8fc > src/common/parse.hpp 8d7ddd6819dad98cd96d5aaae8fe57caf1ee7098 > src/examples/persistent_volume_framework.cpp > c6d6ed337bfca91dc146cb31298cabebdbb13509 > src/local/local.cpp 1953d84c75a83f4ace944d6243456235d8a193ff > src/master/flags.hpp f2cd19a6edfaa4e5bb31f024ef8d5beda32fbc2f > src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f > src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce > src/master/master.hpp ea18c4e0bb0743747401b9cd5ea14ae9b56ae3cc > src/master/master.cpp 351a3c2b5f551ad065682cea601d2436258e4544 > src/tests/authorization_tests.cpp 99bb06c1ee73a90abaeeabb742e45aa188c21a87 > src/tests/cluster.hpp ba17c0c74a9dc36c595c4ad77fe68be94c5c7c0b > src/tests/mesos.hpp 93d87c78e5665b8104dbbc3d1e8c92e515cc67ab > src/tests/mesos.cpp a2a469e2a581dc6c566dafd4acd2a95c0238399f > > Diff: https://reviews.apache.org/r/36048/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
