> On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/flags.cpp, line 81 > > <https://reviews.apache.org/r/37198/diff/1/?file=1033693#file1033693line81> > > > > Is this going to be the same with appc? Should we just have one config?
Changed to /tmp/mesos/containers/docker, to match the structure of other default configured directories in Docker provisioner > On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker.cpp, line 202 > > <https://reviews.apache.org/r/37198/diff/1/?file=1033689#file1033689line202> > > > > Remove extra space between [] and ( > > > > And also seems like we're doing duplicate functionality here with appc? > > Should be consolidate? This part is pretty much the same functionality as with appc. How might we consolidate? With a common provision function? - Lily ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94475 ----------------------------------------------------------- On Aug. 6, 2015, 8:37 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37198/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 8:37 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-2850 > https://issues.apache.org/jira/browse/MESOS-2850 > > > Repository: mesos > > > Description > ------- > > Add Docker image provisioner and copy backend. > > > Diffs > ----- > > src/Makefile.am 35ebbbd0bd9c9dd059c02ce3dc22c780b929be81 > src/slave/containerizer/mesos/containerizer.cpp > 6d07ff151770bac4eeeb7cd8c9d03f54f2e78ec1 > src/slave/containerizer/provisioner.hpp > cb4d511e8189b65df9b9803f23812dd98edc44ac > src/slave/containerizer/provisioner.cpp > df52e36b23ad3cd28f50e96865d0b163cc245cb2 > src/slave/containerizer/provisioners/docker.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/backend.cpp PRE-CREATION > src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 > src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e > > Diff: https://reviews.apache.org/r/37198/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
