> On July 29, 2015, 4:04 p.m., James DeFelice wrote:
> > src/slave/containerizer/isolators/filesystem/linux.cpp, line 238
> > <https://reviews.apache.org/r/36429/diff/1/?file=1009137#file1009137line238>
> >
> >     why MS_SHARED (bidirectional) vs MS_SLAVE (one-way)?
> >     
> >     MS_SLAVE would probably give better isolation to the host mount-ns.
> >     
> >     MS_SHARED would probably be better for a use case that I have in mind 
> > (doc'd in MESOS-349), especially since cleanup() here does GC on mount 
> > points that are children of the sandbox.

SHARED mounts if mainly for propagating persistent volumes (imaging the 
executor has started and a new task with persistent volumes coming in).

The sandbox mount will be shared in host mnt namespace and slave in container 
mnt namespace.

FYI, this patch is being moved to as Ian is on vacation.
https://reviews.apache.org/r/37236/
https://reviews.apache.org/r/37330/


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36429/#review93457
-----------------------------------------------------------


On July 12, 2015, 4:46 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36429/
> -----------------------------------------------------------
> 
> (Updated July 12, 2015, 4:46 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved filesystem/linux from review https://reviews.apache.org/r/34135/
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e5b5d36f0ac160e5a3a9fdc50b31c060a413ce2c 
>   src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION 
>   src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 47d146125dfd4ea909e7ec9d94f41cfa11d035e5 
> 
> Diff: https://reviews.apache.org/r/36429/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to