> On Aug. 8, 2015, 8:37 p.m., Timothy Chen wrote: > > src/slave/containerizer/provisioners/docker/reference_store.cpp, line 186 > > <https://reviews.apache.org/r/37247/diff/1/?file=1035097#file1035097line186> > > > > Why missing layer means we don't load up the image? And when would this > > happen? > > > > We should definitely log here too!
If there is a missing layer, then the Docker image cannot be properly provisioned. Though this cannot currently happen because layers are currently stored forever; once garbage collection is introduced and once layers may be deleted, missing layers may be a possibility. Should I add this as a comment? - Lily ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review94646 ----------------------------------------------------------- On Aug. 10, 2015, 10:53 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37247/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 10:53 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3021 > https://issues.apache.org/jira/browse/MESOS-3021 > > > Repository: mesos > > > Description > ------- > > Added Docker image reference store. > > > Diffs > ----- > > include/mesos/mesos.proto 80f56ac2178b24ff19f57c1ace13f567843c7807 > src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 > src/slave/containerizer/provisioners/docker/reference_store.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/reference_store.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/37247/diff/ > > > Testing > ------- > > make check > > Tests will be added in a later review. > > > Thanks, > > Lily Chen > >
