----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95139 -----------------------------------------------------------
src/slave/containerizer/isolators/filesystem/linux.hpp (lines 105 - 106) <https://reviews.apache.org/r/37236/#comment149972> So this field is really for https://reviews.apache.org/r/37330 but we are not assigning `resources` even there. We should either remove it from this review for now or assign it through the constructor here in this review. - Jiang Yan Xu On Aug. 10, 2015, 3:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37236/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 3:13 p.m.) > > > Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-2794 > https://issues.apache.org/jira/browse/MESOS-2794 > > > Repository: mesos > > > Description > ------- > > Added the linux filesystem isolator. > > Note that the persistent volume part (i.e., update) hasn't been implemented > yet. > > This review is derived from https://reviews.apache.org/r/36429/ > > Tests are in the subsequent review. > > > Diffs > ----- > > src/Makefile.am 942003149b071a322933e2c085d9122903f69713 > src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION > src/slave/containerizer/mesos/containerizer.cpp > 2cbb879888baf6aff76fbd7c1e19027300fb86e3 > > Diff: https://reviews.apache.org/r/37236/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
