> On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 391 > > <https://reviews.apache.org/r/37403/diff/1/?file=1038481#file1038481line391> > > > > Check my earlier comment on how we can simplify this. Also , we need to > > do Accept header validations for ALL call types and not just subscribe.
I'm adding a TODO to move this once we start encoding error messages. In the meantime we shouldn't enforce an 'accept' header to clients if we're sending back for any other type of call 202's or error code with text error messages. > On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: > > src/master/http.cpp, line 394 > > <https://reviews.apache.org/r/37403/diff/1/?file=1038481#file1038481line394> > > > > How about just: > > > > Unsupported 'blah_blah' media type in 'Accept' request-header. The > > supported media types are 'application/json' and 'application/x-protobuf' ? This format was decided in a previous review: see https://reviews.apache.org/r/36037/ for details - Isabel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/#review95135 ----------------------------------------------------------- On Aug. 12, 2015, 5:50 p.m., Isabel Jimenez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37403/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 5:50 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2497 > https://issues.apache.org/jira/browse/MESOS-2497 > > > Repository: mesos > > > Description > ------- > > Using AcceptMediaType Request method to validate request 'Accept' HTTP header > in Scheduler HTTP API > > > Diffs > ----- > > src/master/http.cpp 579c009 > src/tests/http_api_tests.cpp aef3c4b > > Diff: https://reviews.apache.org/r/37403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Isabel Jimenez > >
