> On Aug. 12, 2015, 12:01 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 96-101 > > <https://reviews.apache.org/r/37173/diff/2/?file=1035790#file1035790line96> > > > > I'm not convinced that `addSlave` is the appropriate place to pass the > > unavailability. > > > > This method is called when the agent registers. So, if the maintenance > > schedule is updated after the slave registers, we wouldn't have a > > straightforward route to pass the new schedule info along. > > > > Instead, I think adding another method for passing unavailabilities > > along would be better. We could call that method after agent registration > > or after hitting the maintenance endpoints.
Nevermind. The next review in the chain does exactly this. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review95142 ----------------------------------------------------------- On Aug. 10, 2015, 12:05 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37173/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2015, 12:05 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a > include/mesos/master/allocator.proto > 10fd9a2d5fcbc18a9ca2d6c9c0ec1c605f21872b > src/master/allocator/mesos/allocator.hpp > aa55755a9c3250579e9366bdbc17a2449e95d659 > src/master/allocator/mesos/hierarchical.hpp > e278139f856888d6c6f538f7c0f664087e97f629 > src/master/master.cpp 08dd34d9d18f547c6e8d04caf9e39a2b3ffc5f63 > src/tests/hierarchical_allocator_tests.cpp > c92d47aa0a06088f1f8fe749a629c27bfadd3c6d > src/tests/master_allocator_tests.cpp > 89331965553505f6b7eebf39ad27d943df816a24 > src/tests/mesos.hpp 8b486145dfd2a554689f6e84d76b50508979fea2 > src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b > src/tests/slave_recovery_tests.cpp e1392a2235ff51dac7a3cb7cd3e8edf8406864fc > > Diff: https://reviews.apache.org/r/37173/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
