> On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: > > This thing is rather complex and it deals with Mesos managed persisetent > > volumes and other system volumes in different but related ways; rootfs may > > or may not be used; and we'll provision image volumes later. I hope we > > iterate on this later and look for ways (more documentation, refactorings) > > to simplify and clarify the code.
Yeah, we'll continue to work that later for 'volumes in image'. The involves some refactor. I'll try to think about a way to make it more readable. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95154 ----------------------------------------------------------- On Aug. 12, 2015, 11:21 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37330/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2015, 11:21 p.m.) > > > Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen, > Vinod Kone, and Jiang Yan Xu. > > > Bugs: MESOS-2794 > https://issues.apache.org/jira/browse/MESOS-2794 > > > Repository: mesos > > > Description > ------- > > Added persistent volume support for linux filesystem isolator. > > > Diffs > ----- > > src/slave/containerizer/isolators/filesystem/linux.hpp PRE-CREATION > src/slave/containerizer/isolators/filesystem/linux.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37330/diff/ > > > Testing > ------- > > sudo make check > > Will follow up with more tests specificially for persistent volumes. > > > Thanks, > > Jie Yu > >
