----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review95257 -----------------------------------------------------------
Can this be merged now unless there are more comments? Also needs https://reviews.apache.org/r/34128 - Anindya Sinha On July 30, 2015, 10:36 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34129/ > ----------------------------------------------------------- > > (Updated July 30, 2015, 10:36 p.m.) > > > Review request for mesos and Cosmin Lehene. > > > Bugs: MESOS-809 > https://issues.apache.org/jira/browse/MESOS-809 > > > Repository: mesos > > > Description > ------- > > If set, these IP/Port shall be advertised by libprocess (although bind is > not done on this IP/Port). If not set, libprocess advertises the IP/Port > on which bind was done. > > Command line arguments added: > advertise_ip: IP address advertised to reach mesos master. > advertise_port: Port advertised to reach mesos master (used with > advertise_ip). > > > Diffs > ----- > > docs/configuration.md 506bab15a452f8b1b22328d0c5e9c46af6dfebff > docs/operational-guide.md ef81db672bd5c8fab172336956ab03461ae35064 > src/master/http.cpp 3772e39015a22655dcad00ad844dc5ddc90db43f > src/master/main.cpp e05a472b86170eb26df26aaa4b65437fcdd413ce > > Diff: https://reviews.apache.org/r/34129/diff/ > > > Testing > ------- > > Testing: > make test > > > Thanks, > > Anindya Sinha > >
