> On Aug. 13, 2015, 4:22 p.m., Till Toenshoff wrote: > > src/examples/java/TestFramework.java, line 275 > > <https://reviews.apache.org/r/37415/diff/1/?file=1038842#file1038842line275> > > > > Why 500 - not 200 or 1000? If I am not mistaken, then using 500 worked > > fine on your test-machines but chances are that someone comes in with a > > heavily loaded machine where those 500ms might not do, correct? Let us be > > honest and let the audience know that this is just a value chosen out of > > some test runs done - again, if I did not miss something :) > > > > I think it would also be a great idea to add a todo here that captures > > what you wrote within the JIRA issue already; > > "TODO(*): Ideally, we would inspect the status of the driver and its > > associated tasks via the Java API and wait until their teardown is complete > > to exit."
You are correct! :-) Thanks, comments addressed. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95264 ----------------------------------------------------------- On Aug. 13, 2015, 4:49 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37415/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 4:49 p.m.) > > > Review request for mesos, Joris Van Remoortere, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-830 > https://issues.apache.org/jira/browse/MESOS-830 > > > Repository: mesos > > > Description > ------- > > Fix flaky ExamplesTest.JavaFramework > > > Diffs > ----- > > src/examples/java/TestFramework.java > 265005b9d1a6a053b812c133a4817c3d9e61179e > > Diff: https://reviews.apache.org/r/37415/diff/ > > > Testing > ------- > > This test may fail only infrequently, and the bug is made worse by verbose > logging, so to verify correctness (or reproduce the bug before patching) try: > > GLOG_v=2 GTEST_FILTER="ExamplesTest.JavaFramework" bin/mesos-tests.sh > --verbose --gtest_repeat=100 2>/dev/null | grep "\[" > > > Thanks, > > Greg Mann > >
