----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review95323 -----------------------------------------------------------
src/slave/containerizer/provisioners/docker/store.cpp (line 126) <https://reviews.apache.org/r/37197/#comment150223> Not a good pattern to have magic numbers. Maybe use a constant? src/slave/containerizer/provisioners/docker/store.cpp (line 158) <https://reviews.apache.org/r/37197/#comment150225> add const qualifier ? src/slave/containerizer/provisioners/docker/store.cpp (line 169) <https://reviews.apache.org/r/37197/#comment150226> extra newline? - Jojy Varghese On Aug. 11, 2015, 11:21 p.m., Lily Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37197/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2015, 11:21 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, Jojy Varghese, and Timothy Chen. > > > Bugs: MESOS-2849 > https://issues.apache.org/jira/browse/MESOS-2849 > > > Repository: mesos > > > Description > ------- > > Stored images currently kept indefinitely. > > > Diffs > ----- > > src/Makefile.am c213ac779e7acc3235312ca9524b3959417b8c33 > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp 881d494c06fea5c382d27b357d65c1baf201ae46 > src/slave/flags.cpp 82b6cf47af26f0533ff603a67240777e9a9b986e > > Diff: https://reviews.apache.org/r/37197/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Lily Chen > >
