-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/
-----------------------------------------------------------
(Updated Aug. 14, 2015, 8:17 a.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Updated the interface of the `wait()` method, and refined some of the control
flow.
Summary (updated)
-----------------
[WIP] Added `wait()` method to process::Subprocess
Bugs: MESOS-3035
https://issues.apache.org/jira/browse/MESOS-3035
Repository: mesos
Description (updated)
-------
Jira: MESOS-3035
The original API for `process::Subprocess` still left a lot of legwork
to do for the caller; we have now added a `wait(Duration timeout)` method
that returns a `CommandResult` (also introduced with this patch) which
contains useful information about the command invocation; the exit code;
stdout and, optionally, stderr too.
The `wait()` method will wait for both the process to terminate, and
stdout/stderr to be available to read from; it also "unpacks" them into
ready-to-use `string`s.
This is still WIP as I'm seeing some unusual behavior and I'd like to discuss
with someone more expert on libprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/subprocess.hpp
310cb4f8e4e2faa5545dffd196d7490c868bc5d6
3rdparty/libprocess/src/subprocess.cpp
d6ea62ed1c914d34e0e189395831c86fff8aac22
3rdparty/libprocess/src/tests/subprocess_tests.cpp
ab7515325e5db0a4fd222bb982f51243d7b7e39d
Diff: https://reviews.apache.org/r/37336/diff/
Testing
-------
make check
Thanks,
Marco Massenzio
