----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37489/#review95490 -----------------------------------------------------------
Patch looks great! Reviews applied: [37489] All tests passed. - Mesos ReviewBot On Aug. 14, 2015, 8:23 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37489/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 8:23 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This change makes scheduler tests parameterized. > > - I had to disable SchedulerTests.KillTask due to the JSON encoding issue > till we fix it. I can un-parameterize it for now too ? > - Moved the ContentType/output overload operators to include/mesos/http.hpp > > > Diffs > ----- > > include/mesos/http.hpp PRE-CREATION > include/mesos/v1/scheduler.hpp dddc494dffc953436af3431094f9cf1bba6a19ba > src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 > src/common/http.hpp 0eab8ba2033783b6d97b1a40849929742b4db099 > src/common/http.cpp e2ff48ca609f1c97a1b6c20cc6be3d97c3e4bb50 > src/scheduler/scheduler.cpp 2d2bd5eb796d93fdb24ab363cdf07f7362fa3803 > src/tests/scheduler_tests.cpp 7842f27673cc0fc11864916dda4ca4bbb66d9dbd > > Diff: https://reviews.apache.org/r/37489/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
