----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37460/#review95607 -----------------------------------------------------------
src/tests/containerizer/perf_tests.cpp (lines 65 - 67) <https://reviews.apache.org/r/37460/#comment150683> Hm.. we still have assertions in this test, so could we just change this CHECK to an ASSERT and leave the test as is? It doesn't seem worth introducing conditional logic here to try to proceed when we still haven't eliminated ASSERTs that can fail the test. ASSERTs are ok since our tests should be passing :) src/tests/containerizer/perf_tests.cpp (lines 116 - 117) <https://reviews.apache.org/r/37460/#comment150682> This will crash when parse doesn't contain "" - Ben Mahler On Aug. 14, 2015, 3:01 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37460/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 3:01 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2834 > https://issues.apache.org/jira/browse/MESOS-2834 > > > Repository: mesos > > > Description > ------- > > Prevent perf test failures from killing the test harness. > > > Diffs > ----- > > src/tests/containerizer/perf_tests.cpp > 6b3d70f3e7ea8f59f94e6961491d4e9a730e3334 > > Diff: https://reviews.apache.org/r/37460/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
