> On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 474-478 > > <https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line474> > > > > Why `_supported` here that takes a version? Why not just have supported > > compute the version and then perform the necessary check?
We need two variants - perf::supported that computes the version and performs the necessary checks, and a version for testing that we can feed fake version information into so that we can test the parsing against multiple versions of perf output. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95809 ----------------------------------------------------------- On Aug. 20, 2015, 1:13 a.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37416/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2015, 1:13 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > Perf supported() should be based on the version of perf, not the version of > the kernel. > > > Diffs > ----- > > src/linux/perf.cpp cdc5f8314a875ababf2b17a32873775d808e1c78 > > Diff: https://reviews.apache.org/r/37416/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Paul Brett > >
