----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37479/#review96170 -----------------------------------------------------------
Ship it! LGTM, sorry for the long turn around time on this review - a few style nits in the make file, but otherwise good to go. src/Makefile.am (line 476) <https://reviews.apache.org/r/37479/#comment151475> Is the indentation of the '\' right here? Set tabstop to 8 and use hard tabs. Also, is this sorted correctly? src/Makefile.am (line 754) <https://reviews.apache.org/r/37479/#comment151476> Same comments as above - Niklas Nielsen On Aug. 14, 2015, 6:44 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37479/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 6:44 p.m.) > > > Review request for mesos, Niklas Nielsen and Vinod Kone. > > > Bugs: MESOS-3261 > https://issues.apache.org/jira/browse/MESOS-3261 > > > Repository: mesos > > > Description > ------- > > We need to move QoS plug-ins to a specified folder like > resource_estimators, this can make sure new plug-ins can be put > into the folders for resource estimator and qos controller. > > > Diffs > ----- > > src/Makefile.am e990369139e7ac3b86f8b04cfd5bef559e16dd24 > src/examples/test_qos_controller_module.cpp > 156529d2392572d2968f788e385b0a798ece33b5 > src/slave/qos_controller.hpp 6188a7485f0c2870f925ec4c69b40c9ae44b23fa > src/slave/qos_controller.cpp 57883686c6e4333fc1a246a758e7dd861556d6fa > src/slave/qos_controllers/noop.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37479/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
