----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37364/#review96315 -----------------------------------------------------------
Ship it! Ship It! - Guangya Liu On Aug. 24, 2015, 7:09 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37364/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 7:09 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2067 > https://issues.apache.org/jira/browse/MESOS-2067 > > > Repository: mesos > > > Description > ------- > > Endpoint: /maintenance.status > > Returns a JSON object like: > ``` > { > "draining": [ > { "hostname": "foo", "ip": "0.0.0.1" }, > { "hostname": "bar", "ip": "0.0.0.2" }, > ], > "deactivated": [ > { "hostname": "baz", "ip": "0.0.0.3" }, > ] > } > ``` > > > Diffs > ----- > > src/master/http.cpp 37d76ee72f6a037f551bf2609e9393e16b496e44 > src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be > src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf > src/tests/master_maintenance_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37364/diff/ > > > Testing > ------- > > `make check` > > New Tests: > MasterMaintenanceTest.FailToUnscheduleDeactivatedMachines > Extra test case for the /maintenance.schedule endpoint, which requires > all three endpoints to work. > MasterMaintenanceTest.MachineStatus > Schedules, starts, and stops maintenance. Checks machine statuses after > each step. > > > Thanks, > > Joseph Wu > >
