----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37722/#review96372 -----------------------------------------------------------
Ship it! src/slave/containerizer/provisioners/appc/paths.hpp (line 52) <https://reviews.apache.org/r/37722/#comment151710> s/appc/APPC/ src/slave/containerizer/provisioners/appc/paths.hpp (line 53) <https://reviews.apache.org/r/37722/#comment151712> How about the following layout: `APPC/containers/<container_id>` IN that way, it's more easy to add any metadata that is not associated with any container. src/slave/containerizer/provisioners/appc/paths.hpp (line 54) <https://reviews.apache.org/r/37722/#comment151716> Similarly, can you use the following layout: `<container_id>/backends/<backend>/...` src/slave/containerizer/provisioners/appc/paths.hpp (line 59) <https://reviews.apache.org/r/37722/#comment151717> s/docker/DOCKER/ src/slave/paths.cpp (line 457) <https://reviews.apache.org/r/37722/#comment151702> You can use stringify(imageType) directly. You might need to add a "<<" operator for Image::Type - Jie Yu On Aug. 24, 2015, 6:26 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37722/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 6:26 p.m.) > > > Review request for mesos, Lily Chen, Chi Zhang, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-3308 > https://issues.apache.org/jira/browse/MESOS-3308 > > > Repository: mesos > > > Description > ------- > > More context in /r/37382/ and MESOS-3308. > > I will add the appc backend + provisioner implementation shortly but would > like to seek feedback about this design early. > > > Diffs > ----- > > src/slave/containerizer/provisioners/appc/paths.hpp > e35805179e67770c6eff7406668caecabefe4fea > src/slave/containerizer/provisioners/appc/paths.cpp > a244d9a40e7143134b7bf883514bfcd04d6a6af5 > src/slave/paths.hpp dbb1f68d8a789303b595d9e455e2f6f1f0de5c5b > src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2 > > Diff: https://reviews.apache.org/r/37722/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
