----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review96453 -----------------------------------------------------------
Can you split the addition of suppress to the driver (sched.cpp) and http library (scheduler.cpp) into separate patches? Note that the former needs updates to the Java and Python bindings as well. More importantly, are you planning to plumb this call through to the allocator to actually do the quiescing/suppressing? - Vinod Kone On Aug. 22, 2015, 2:27 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37532/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2015, 2:27 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3037 > https://issues.apache.org/jira/browse/MESOS-3037 > > > Repository: mesos > > > Description > ------- > > This is just part of MESOS-3037, this patch only add the interface > of QUIESCE call. > > > Diffs > ----- > > include/mesos/scheduler.hpp ee198b6955882f4f31466ca05429ca16fbf2f5cd > include/mesos/scheduler/scheduler.proto > 89daf8a6b74057ee156b3ad691397e76fcb835b8 > include/mesos/v1/scheduler/scheduler.proto > bd5e82a614b1163b29f9b20e562208efa1ba4b55 > src/master/master.hpp 0432842d77beba024c7895291ca410964bae96be > src/master/master.cpp c5e6c6f3304060d4c92d52851951f10bc432500e > src/sched/sched.cpp 012af0508eeceeccd168b29f36fa258d20b28c21 > src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 > > Diff: https://reviews.apache.org/r/37532/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
