----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37813/#review96607 -----------------------------------------------------------
Ship it! Looks good. src/tests/fetcher_cache_tests.cpp (line 235) <https://reviews.apache.org/r/37813/#comment152197> Possibly want a comment explaining that this is meant for directories with logs. If it's mistakenly pointed to, say, a directory with a binary, the output could get messy. src/tests/fetcher_cache_tests.cpp (line 458) <https://reviews.apache.org/r/37813/#comment152198> Is it common knowledge that the sandbox holds the logs? (If not, a short comment would suffice.) - Joseph Wu On Aug. 26, 2015, 2:08 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37813/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 2:08 p.m.) > > > Review request for mesos, Benjamin Hindman, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-3235 > https://issues.apache.org/jira/browse/MESOS-3235 > > > Repository: mesos > > > Description > ------- > > Dumps all involved task/executor sandbox contents in test tear down > only if a failure occurred. > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp b709b1eedeb880bc815e0742dc604d93828e593f > > Diff: https://reviews.apache.org/r/37813/diff/ > > > Testing > ------- > > make check on OSX, where the bug showed up. > > > Thanks, > > Bernd Mathiske > >
