----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96897 -----------------------------------------------------------
Patch looks great! Reviews applied: [37894] All tests passed. - Mesos ReviewBot On Aug. 28, 2015, 4:39 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37894/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 4:39 p.m.) > > > Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-3086 > https://issues.apache.org/jira/browse/MESOS-3086 > > > Repository: mesos > > > Description > ------- > > As this function is actually just sending the signal we renamed it. > Additionally we want to introduce an actual cgroups::kill() with MESOS-3086. > > > Diffs > ----- > > src/linux/cgroups.hpp 204c53038a1ccfa693f4f2293488cff8cdd60835 > src/linux/cgroups.cpp 6ef42ed1bc719f334d1ac6e90919a1bc1840d31f > src/tests/containerizer/cgroups_tests.cpp > 0b171eeb53037f26b7e952830e88e59f1278e7c6 > > Diff: https://reviews.apache.org/r/37894/diff/ > > > Testing > ------- > > > Thanks, > > Joerg Schad > >