----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96916 -----------------------------------------------------------
Maybe you can kill this entire review however given my comments below? src/internal/evolve.cpp (lines 162 - 163) <https://reviews.apache.org/r/37282/#comment152610> See comment below. src/messages/messages.proto (line 171) <https://reviews.apache.org/r/37282/#comment152609> Let's not add this yet. - Benjamin Hindman On Aug. 26, 2015, 2:12 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37282/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 2:12 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu. > > > Bugs: MESOS-1474 > https://issues.apache.org/jira/browse/MESOS-1474 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/internal/devolve.hpp 6e4306df78b9b8d2054e6550209341fd7b0972d6 > src/internal/devolve.cpp 0a069e51053b572a8d5dc95380732119504dd0c9 > src/internal/evolve.hpp 13e9f52da98567038ec717f394f79e526a1521e9 > src/internal/evolve.cpp 11ce9e77490e93f781ceebc33063d13953a11765 > src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c > > Diff: https://reviews.apache.org/r/37282/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >