----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/#review97113 -----------------------------------------------------------
cmake/MesosConfigure.cmake (line 76) <https://reviews.apache.org/r/37275/#comment152864> This comment doesn't need to change. If anything, you could add an extra line, like: ``` Your version of MSVC is ${MSVC_VERSION}. ``` Or: ``` Mesos does not support compiling on MSVC version ${MSVC_VERSION}, which is earlier than version 1900. ``` cmake/MesosConfigure.cmake (line 125) <https://reviews.apache.org/r/37275/#comment152883> Why do you need this? (If you do need it, comment why.) It doesn't look like the inputs have any semicolons. - Joseph Wu On Aug. 30, 2015, 6:42 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37275/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2015, 6:42 a.m.) > > > Review request for mesos and Alex Clemmer. > > > Repository: mesos > > > Description > ------- > > Generate make batch file to build project in windows. > > > Diffs > ----- > > CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > > Diff: https://reviews.apache.org/r/37275/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
