----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38050/#review97621 -----------------------------------------------------------
Patch looks great! Reviews applied: [38050] All tests passed. - Mesos ReviewBot On Sept. 3, 2015, 7:46 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38050/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2015, 7:46 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-1831 > https://issues.apache.org/jira/browse/MESOS-1831 > > > Repository: mesos > > > Description > ------- > > Master should send PingSlaveMessage instead of "PING"; Slave should accept > PingSlaveMessage but not "PING" message; > > > Diffs > ----- > > src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 > src/tests/partition_tests.cpp b7030adcfb1bfb128040aff20f12461412b5382c > src/tests/slave_recovery_tests.cpp 4d137e0f1278fdacf71f101b1967df35bfbcdd23 > src/tests/slave_tests.cpp 24119183ef04961fe2fdac73de7672cbe5b2408c > > Diff: https://reviews.apache.org/r/38050/diff/ > > > Testing > ------- > > Test2: Start master and slave to debug the PingSlaveMessage. Passed! > Test1: Run make check successfully! > > > Thanks, > > Yong Qiao Wang > >
