> On Sept. 3, 2015, 12:46 a.m., Vinod Kone wrote: > > src/linux/perf.hpp, lines 84-89 > > <https://reviews.apache.org/r/37540/diff/5/?file=1062756#file1062756line84> > > > > Do we need this overload considering users can call the overload below?
I think it is still useful, because the return value of the other overload is a hashmap, not convenient to use for a single cgroup. - Cong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review97548 ----------------------------------------------------------- On Sept. 2, 2015, 10:16 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37540/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 10:16 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-2769 > https://issues.apache.org/jira/browse/MESOS-2769 > > > Repository: mesos > > > Description > ------- > > Abstract Linux kernel perf event API and provide API to collect schedule > events. > > > Diffs > ----- > > src/linux/perf.hpp c44445630118f4858b1a805f25a2db7a24ca0989 > src/linux/perf.cpp bb8b5918e4c8f4379784d4fa18c3b4709696e1ea > src/tests/containerizer/perf_tests.cpp > 8c29ca3dc2a8f6d1fb0f430482190f87f08eb4e8 > > Diff: https://reviews.apache.org/r/37540/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Cong Wang > >