----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97843 -----------------------------------------------------------
include/mesos/mesos.proto (line 915) <https://reviews.apache.org/r/38074/#comment153904> Can you please add some commentes here to declear what does p50, p90, p95, p99 mean? Thanks. src/slave/flags.cpp (line 306) <https://reviews.apache.org/r/38074/#comment153905> Interval between which two values? src/slave/flags.cpp (line 307) <https://reviews.apache.org/r/38074/#comment153906> Does this also affect the event, so what is the difference of this flag and sched_sample_duration? - Guangya Liu On 九月 4, 2015, 11:16 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38074/ > ----------------------------------------------------------- > > (Updated 九月 4, 2015, 11:16 p.m.) > > > Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone. > > > Bugs: MESOS-2769 > https://issues.apache.org/jira/browse/MESOS-2769 > > > Repository: mesos > > > Description > ------- > > Finally, calculate schedule latency with the sched trace events, and add it > to our statistics > > > Diffs > ----- > > include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c > src/slave/containerizer/isolators/cgroups/perf_event.hpp > 1f722ef3ef7ab7fce5542d4affae961d6cec2406 > src/slave/containerizer/isolators/cgroups/perf_event.cpp > 7dc8b7a99074b74ade019ef4df296780650a2e4e > src/slave/flags.hpp b8335aa585376d27b71897f8cbaefaa12f4b3a5c > src/slave/flags.cpp 7539441c685828027db07173e62a4e5fc1e8b54d > > Diff: https://reviews.apache.org/r/38074/diff/ > > > Testing > ------- > > manual tests > > > Thanks, > > Cong Wang > >
