> On Sept. 6, 2015, 8:49 a.m., Joerg Schad wrote: > > src/examples/dynamic_reservation_framework.cpp, line 283 > > <https://reviews.apache.org/r/37168/diff/4/?file=1064720#file1064720line283> > > > > s/TASK_DONE/TASKS_DONE > > > > Please correct me if I am wrong: TASK_DONE is a global state across all > > slaves, while the other states can differ per state, or? Maybe just extend > > the comment a bit explaining this.
Yes, TASK_DONE is a global state; when all task finished, framework will un-reserve all resources. > On Sept. 6, 2015, 8:49 a.m., Joerg Schad wrote: > > src/tests/dynamic_reservation_framework_test.sh, line 30 > > <https://reviews.apache.org/r/37168/diff/4/?file=1064721#file1064721line30> > > > > Do we need this here and below in script.cpp? Yes, it's necessary because: 1. dynamic reservation is role based 2. can not use default role for dynamic reservation, neither * nor MESOS_DEFAULT_ROLE > On Sept. 6, 2015, 8:49 a.m., Joerg Schad wrote: > > src/Makefile.am, line 1463 > > <https://reviews.apache.org/r/37168/diff/4/?file=1064719#file1064719line1463> > > > > Any reason for this blank line here? It's not necessary, will delete it. > On Sept. 6, 2015, 8:49 a.m., Joerg Schad wrote: > > src/examples/dynamic_reservation_framework.cpp, line 281 > > <https://reviews.apache.org/r/37168/diff/4/?file=1064720#file1064720line281> > > > > s/get/receives OK :). - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97885 ----------------------------------------------------------- On Sept. 6, 2015, 4:11 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37168/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2015, 4:11 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-3063 > https://issues.apache.org/jira/browse/MESOS-3063 > > > Repository: mesos > > > Description > ------- > > Provide example for dynamic reservation features. > > > Diffs > ----- > > src/Makefile.am 5fdca0f > src/examples/dynamic_reservation_framework.cpp PRE-CREATION > src/tests/dynamic_reservation_framework_test.sh PRE-CREATION > src/tests/examples_tests.cpp 3f56b30 > src/tests/flags.hpp 06da36d > src/tests/script.cpp bcc1fab > > Diff: https://reviews.apache.org/r/37168/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Klaus Ma > >
