----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review97950 -----------------------------------------------------------
src/docker/docker.cpp (line 414) <https://reviews.apache.org/r/38165/#comment154086> Should we provide UT for this fix? please refer to the other test in "src/tests". - Klaus Ma On Sept. 7, 2015, 6:47 p.m., Wojciech Sielski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38165/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2015, 6:47 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3377 > https://issues.apache.org/jira/browse/MESOS-3377 > > > Repository: mesos > > > Description > ------- > > MESOS-3377 - Adding CONTAINER_NAME as additional env variable > > > Diffs > ----- > > src/docker/docker.cpp ec2de5436ef5261a7d04eebeeded58435774cd9e > > Diff: https://reviews.apache.org/r/38165/diff/ > > > Testing > ------- > > Every docker container that is created by mesos, > gonna get conatiner dynamic env variable CONTAINER_NAME. > So it is easy to use by 3rd party application, > for example: when use with registartor/consul > so is it's much easier to deregister itself > (or put into maintanance mode) before being killed. > > > Tested and verified afetr build locally. > > > Thanks, > > Wojciech Sielski > >
