> On Sept. 15, 2015, 12:17 a.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/docker/provisioner.cpp, lines 376-379 > > <https://reviews.apache.org/r/38137/diff/8/?file=1068176#file1068176line376> > > > > The logic here also changes in AppcProvisioner. Please make sure it's > > in sync. Or just unify the Provisioner.
I did not see any slightly logic change here. We may be able to have docker provisioner here to test it, and create another issue to unify DOCKER and APPC provisioner. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98965 ----------------------------------------------------------- On Sept. 11, 2015, 7:42 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38137/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 7:42 a.m.) > > > Review request for mesos, Jie Yu, Jojy Varghese, Till Toenshoff, and Jiang > Yan Xu. > > > Repository: mesos > > > Description > ------- > > Joining all the commits around provisioner and local store into one review so > it's easier to review, as patches > are changing code on top of each other. > > All the commits are going to committed together. > > > Diffs > ----- > > src/Makefile.am 8963cea > src/slave/containerizer/provisioner.hpp 9e0e0b8 > src/slave/containerizer/provisioner.cpp 2ac9008 > src/slave/containerizer/provisioners/docker/local_store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/local_store.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/message.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/message.proto PRE-CREATION > src/slave/containerizer/provisioners/docker/metadata_manager.hpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/metadata_manager.cpp > PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/paths.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/provisioner.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/provisioner.cpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.hpp PRE-CREATION > src/slave/containerizer/provisioners/docker/store.cpp PRE-CREATION > src/slave/flags.hpp 799c963 > src/slave/flags.cpp b676bac > src/tests/containerizer/docker_provisioner_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38137/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
