----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99635 -----------------------------------------------------------
docs/maintenance.md (line 25) <https://reviews.apache.org/r/37585/#comment156575> s/adds/add/. docs/maintenance.md (line 27) <https://reviews.apache.org/r/37585/#comment156576> Did the notion of an operator not exist before Maintenance Primitives were introduced? I would rephrase the sentence above to say that we're definining terms for the puropse of this doc. docs/maintenance.md (line 35) <https://reviews.apache.org/r/37585/#comment156577> s/in/during/ s/may not be/may become/ docs/maintenance.md (line 36) <https://reviews.apache.org/r/37585/#comment156579> s/about the/about the availability of the/ docs/maintenance.md (line 40) <https://reviews.apache.org/r/37585/#comment156580> s/will have unavailability info attached/will contain unavailability information/ docs/maintenance.md (lines 72 - 73) <https://reviews.apache.org/r/37585/#comment156581> Please add anchors to links so that the relevant parts of the .proto file in each case are highlighted. docs/maintenance.md (line 75) <https://reviews.apache.org/r/37585/#comment156582> s/the schedule is/the schedule must be/ docs/maintenance.md (lines 91 - 92) <https://reviews.apache.org/r/37585/#comment156583> Can they also specify seconds? If not, we should definitely add a JIRA for that (as a syntactic sugar for the interface). Please mention somewhere that start is the nanoseconds since epoch. docs/maintenance.md (line 107) <https://reviews.apache.org/r/37585/#comment156584> s/this schedule/the schedule/ docs/maintenance.md (line 118) <https://reviews.apache.org/r/37585/#comment156585> s/if, say, a faulty machine launches agents on boot./to, say, prevent a faulty machine from launching an agent on boot./ docs/maintenance.md (line 120) <https://reviews.apache.org/r/37585/#comment156586> What does this mean for the person reading this? Should they supply extra options through the agent command line? Should they make sure that their /etc/hosts is sane? This is currently not actionable, but it has to be. docs/maintenance.md (line 127) <https://reviews.apache.org/r/37585/#comment156588> What if one or several of the checks fail? docs/maintenance.md (line 133) <https://reviews.apache.org/r/37585/#comment156589> Isn't this one obvious? docs/maintenance.md (line 134) <https://reviews.apache.org/r/37585/#comment156590> What does this mean? What if they aren't? docs/maintenance.md (line 135) <https://reviews.apache.org/r/37585/#comment156591> Please explain a recommended workflow for updating maintenance schedule, and canceling it. docs/maintenance.md (lines 144 - 145) <https://reviews.apache.org/r/37585/#comment156592> Does this potentially mean a mass task restart across the nodes that are undergoing maintenance? docs/maintenance.md (line 190) <https://reviews.apache.org/r/37585/#comment156593> a link to .proto would be helpful here too. docs/maintenance.md (line 203) <https://reviews.apache.org/r/37585/#comment156595> Again, not clear what happens if one of these conditions fails. docs/maintenance.md (line 224) <https://reviews.apache.org/r/37585/#comment156597> s/maintenance starts/maintenance is triggered by the operator/. docs/maintenance.md (line 235) <https://reviews.apache.org/r/37585/#comment156598> Link to .proto, please? docs/maintenance.md (line 249) <https://reviews.apache.org/r/37585/#comment156599> s/guess/a best effort guess/ - Artem Harutyunyan On Sept. 18, 2015, 12:51 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37585/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 12:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Artem Harutyunyan, > Joris Van Remoortere, and Vinod Kone. > > > Bugs: MESOS-2083 > https://issues.apache.org/jira/browse/MESOS-2083 > > > Repository: mesos > > > Description > ------- > > Heavily based on the design doc > (https://docs.google.com/document/d/16k0lVwpSGVOyxPSyXKmGC-gbNmRlisNEe4p-fAUSojk/). > > Includes a diagram of the maintenance mode transitions. > > > Diffs > ----- > > docs/images/maintenance-primitives-modes.png PRE-CREATION > docs/maintenance.md PRE-CREATION > > Diff: https://reviews.apache.org/r/37585/diff/ > > > Testing > ------- > > Copied to: https://gist.github.com/kaysoky/b9789c88ee204e3b49a2 > Checked for markdown correctness. > > > File Attachments > ---------------- > > Same as the image in the binary diff. (Uploaded for reviewer convenience.) > > https://reviews.apache.org/media/uploaded/files/2015/09/01/7d3153ca-37f4-4948-acce-b140a3eb71a9__maintenance-primitives-modes.png > > > Thanks, > > Joseph Wu > >
