----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38540/#review99721 -----------------------------------------------------------
Patch looks great! Reviews applied: [38456, 38457, 38529, 38530, 38531, 38538, 38539, 38540] All tests passed. - Mesos ReviewBot On Sept. 21, 2015, 2:41 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38540/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 2:41 a.m.) > > > Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3434 > https://issues.apache.org/jira/browse/MESOS-3434 > > > Repository: mesos > > > Description > ------- > > Generate make batch file to build project in windows. > > This commit is the product of two reviews; the first one[1], by > haosdent, was lightly rebased by hausdorff to target a later HEAD, and > then augmented to fix the broken Ubuntu 14.04 build that this commit > caused. Other than those things, the review is functionally identical to > the original, and all credit for the work should go to haosdent. > > [1] Original review: https://reviews.apache.org/r/37275 > > > Diffs > ----- > > CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 > cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 > > Diff: https://reviews.apache.org/r/38540/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Windows 10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
