----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/#review100034 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/cmake/ProcessConfigure.cmake (lines 59 - 65) <https://reviews.apache.org/r/38542/#comment157118> What do you think about moving this `if` block into `Versions.cmake`? Pro: Versions are kept in one place. If we unilaterally update to glog 0.3.4, we'll only need to update it in one place. Con: Logic in the version file, which we don't really have a precedent for. - Joseph Wu On Sept. 20, 2015, 8:23 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38542/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2015, 8:23 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Currently we configure the version information of third-party > dependencies in the CMake build system from magic strings. > > This commit will transition away from the magic string solution and > towards the variables we define in `Versions.cmake`. > > > Diffs > ----- > > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > a5f8d399e151acad87bb72ecb1f7372b2c467423 > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake > 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e > > Diff: https://reviews.apache.org/r/38542/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Windows 10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
