> On Sept. 22, 2015, 12:40 a.m., Connor Doyle wrote: > > Ship It! > > Connor Doyle wrote: > Please re-run the post-reviews so the patch applies cleanly > (`src/slave/http.cpp` was concurrently modified). > > Felix Abecassis wrote: > Done. Please verify.
Verified (patch applied, make, make check). - Connor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38517/#review99883 ----------------------------------------------------------- On Sept. 22, 2015, 1:26 a.m., Felix Abecassis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38517/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 1:26 a.m.) > > > Review request for mesos, Connor Doyle and Niklas Nielsen. > > > Bugs: MESOS-3366 > https://issues.apache.org/jira/browse/MESOS-3366 > > > Repository: mesos > > > Description > ------- > > This is required in order to enable callback hooks that can modify attributes > of a slave during initialization. > > > Diffs > ----- > > include/mesos/attributes.hpp PRE-CREATION > src/Makefile.am e224060 > src/common/attributes.hpp 2a7efbd > src/common/attributes.cpp f713bb5 > src/common/http.hpp 058baa6 > src/common/http.cpp aaef10b > src/common/type_utils.cpp 22118b4 > src/master/http.cpp 3e44b06 > src/slave/http.cpp 12a4d39 > src/slave/slave.hpp 7a54fad > src/tests/attributes_tests.cpp ded6120 > src/tests/registrar_tests.cpp 5131b57 > > Diff: https://reviews.apache.org/r/38517/diff/ > > > Testing > ------- > > > Thanks, > > Felix Abecassis > >
