----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/#review100612 -----------------------------------------------------------
LGTM. - Artem Harutyunyan On Sept. 21, 2015, 4:21 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38552/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 4:21 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3383 > https://issues.apache.org/jira/browse/MESOS-3383 > > > Repository: mesos > > > Description > ------- > > APR is required for Mesos to run. Normally we expect that a user has > obtained APR with their favorite package manager, but on Windows, we > cannot really expect that this is the case. So, we have to rope in the > dependency manually in the CMake build system. > > This commit will introduce the necessary build targets to obtain, > configure, build, and install APR for Windows builds. It will ignore APR > and assume it's there for Linux builds. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/CMakeLists.txt > b9c9fae7d448906e9c9f5ab0ee3fe138a0171a7d > 3rdparty/libprocess/cmake/ProcessConfigure.cmake > a5f8d399e151acad87bb72ecb1f7372b2c467423 > > Diff: https://reviews.apache.org/r/38552/diff/ > > > Testing > ------- > > Compiled and ran made sure libprocess and stout tests ran and passed on the > following platforms: > > * OS X 10.10 > * Windows 10 > * Ubuntu 14.04.2 > > > Thanks, > > Alex Clemmer > >
