----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100688 -----------------------------------------------------------
src/slave/state.cpp (line 656) <https://reviews.apache.org/r/38774/#comment157949> Can be moved upper, out of this if/else, save one line of code. ;) src/slave/state.cpp (line 746) <https://reviews.apache.org/r/38774/#comment157950> Ditto - Cong Wang On Sept. 25, 2015, 9 p.m., Chi Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38774/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 9 p.m.) > > > Review request for mesos. > > > Bugs: mesos-3519 > https://issues.apache.org/jira/browse/mesos-3519 > > > Repository: mesos > > > Description > ------- > > state: fix file descriptor leak > > > Diffs > ----- > > src/slave/state.cpp 47c66dc80d57db86981769d404c2c8c7c972fec0 > > Diff: https://reviews.apache.org/r/38774/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Chi Zhang > >
