> On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, line 58 > > <https://reviews.apache.org/r/37853/diff/1/?file=1056428#file1056428line58> > > > > You also want to check if overlay fs is supported or not. Not every > > linux kernel supports overlay fs. > > Mei Wan wrote: > How would I check this?
Well, i'll let you to figure this out :) Hint: google /proc/filesystems > On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, lines 110-114 > > <https://reviews.apache.org/r/37853/diff/1/?file=1056428#file1056428line110> > > > > Could you please add a comment about the ordering the layers will be > > stacked. > > > > I think we should add a document at the backend interface as well > > stating that layers are stacking in such a way that the front layer in the > > vector will be the bottom most layer (i.e., applied first). > > > > The lowerdir here should actually reverse the order of the layers > > vector. > > > > ``` > > The specified lower directories will be stacked beginning from the > > rightmost one and going left. In the above example lower1 will be the top, > > lower2 the middle and lower3 the bottom layer. > > ``` > > Mei Wan wrote: > Where would I add this document? I could just add it to the flag? You can just add that commments right above this code block. > On Aug. 27, 2015, 10:42 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioners/backends/overlay.cpp, line 111 > > <https://reviews.apache.org/r/37853/diff/1/?file=1056428#file1056428line111> > > > > I think you should be able to use strings::join here: > > > > ``` > > strings::join(":", layers); > > ``` > > Mei Wan wrote: > The format would be dir1:dir2:dir3 etc. I'm just wondering is it possible > to have the semi colon only appear between the directories? If I'm thinking > about this correctly, strings::join will give me :dir1:dir2:dir3? Also since > I'm stacking the layers in reverse from the comment above, does this still > apply? strings::join will give you dir1:dir2:dir3 (exactly what you want). - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review96763 ----------------------------------------------------------- On Aug. 27, 2015, 9:11 p.m., Mei Wan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37853/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 9:11 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2971 > https://issues.apache.org/jira/browse/MESOS-2971 > > > Repository: mesos > > > Description > ------- > > Implemented the overlay filesystem backend by layering the images as a > read-only filesystem. > > > Diffs > ----- > > src/Makefile.am 7b620ff > src/slave/containerizer/provisioners/backend.cpp 2f7c335 > src/slave/containerizer/provisioners/backends/overlay.hpp PRE-CREATION > src/slave/containerizer/provisioners/backends/overlay.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37853/diff/ > > > Testing > ------- > > I haven't done any official testing. When I was working off Ian's branch, I > tested it manually and the provisioning works. > > > Thanks, > > Mei Wan > >
