> On Sept. 28, 2015, 4:18 p.m., Mesos ReviewBot wrote: > > Bad review! > > > > Reviews applied: [] > > > > Error: > > No reviewers specified. Please find a reviewer by asking on JIRA or the > > mailing list. > > Chris Chen wrote: > FINE.
Doesn't look like the change to 3rdparty/CMakeLists.txt is attached? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38815/#review100888 ----------------------------------------------------------- On Sept. 28, 2015, 4:24 p.m., Chris Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38815/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 4:24 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3391 > https://issues.apache.org/jira/browse/MESOS-3391 > > > Repository: mesos > > > Description > ------- > > Problem: > The Zookeeeper C client does makes certain assertions about the ordering > of ping packets that the Java client does not. An alternate implementation > of the Zookeeper server would then break the C client while working > correctly with the Java client. > > Solution: > Port change from ZOOKEEPER-2253 to make C client handle pings similarly > to the Java client. > > Result: > C client and Java clients behave the same when dealing with an out-of-order > ping packet. > > > Diffs > ----- > > 3rdparty/Makefile.am 7c244a053044ae347f9505cb78a71a6636e26586 > 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da > > Diff: https://reviews.apache.org/r/38815/diff/ > > > Testing > ------- > > Tested from upstream; Running mesos check succeeds. > > > Thanks, > > Chris Chen > >
