----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38855/#review101009 -----------------------------------------------------------
Ship it! src/tests/containerizer/fs_tests.cpp (line 198) <https://reviews.apache.org/r/38855/#comment158309> Can you get the mount id before you do the mount and then verify the shared sibling id is correct? This might be easiest to do with a second self bind mount so you can find the sibling. src/tests/containerizer/fs_tests.cpp (line 200) <https://reviews.apache.org/r/38855/#comment158308> s/Cleanup/Clean up/ src/tests/containerizer/fs_tests.cpp (line 201) <https://reviews.apache.org/r/38855/#comment158312> So the mount won't get cleaned up if the test asserts early? src/tests/containerizer/fs_tests.cpp (line 241) <https://reviews.apache.org/r/38855/#comment158311> Like above, can you verify the master id is correct? src/tests/containerizer/fs_tests.cpp (line 243) <https://reviews.apache.org/r/38855/#comment158310> s/Cleanup/Clean up/ - Ian Downes On Sept. 29, 2015, 12:09 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38855/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 12:09 p.m.) > > > Review request for mesos, Ian Downes, Timothy Chen, and Jiang Yan Xu. > > > Bugs: MESOS-3539 > https://issues.apache.org/jira/browse/MESOS-3539 > > > Repository: mesos > > > Description > ------- > > Added support for getting shared and slave mount peer group ID. > > > Diffs > ----- > > src/linux/fs.hpp f3aa0c2a385527eab5895f5d10c29e3d68e30a49 > src/linux/fs.cpp 8631d892ed6c132d6a9dc2031c2ca040623e9acc > src/tests/containerizer/fs_tests.cpp > 34d3c41045373326fb6096031cd1daef0e7b203a > > Diff: https://reviews.apache.org/r/38855/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
