> On Oct. 6, 2015, 1:55 a.m., Cong Wang wrote: > > src/tests/containerizer/isolator_tests.cpp, line 1206 > > <https://reviews.apache.org/r/38527/diff/3/?file=1089403#file1089403line1206> > > > > Looks like you are replicating the same code from > > ContainerizerTest<slave::MesosContainerizer>::SetUp(), why that code is not > > enough and is it possible to reuse that code?
I am not sure UserCgroupIsolatorTest should extends from ContainerizerTest or not before. Let me make UserCgroupIsolatorTest extends ContainerizerTest. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/#review101575 ----------------------------------------------------------- On Oct. 3, 2015, 4:15 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38527/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 4:15 p.m.) > > > Review request for mesos, Ian Downes, Jie Yu, and Cong Wang. > > > Bugs: MESOS-3470 > https://issues.apache.org/jira/browse/MESOS-3470 > > > Repository: mesos > > > Description > ------- > > Fix UserCgroupIsolatorTest failed on CentOS 6.6. > > > Diffs > ----- > > src/tests/containerizer/isolator_tests.cpp > 237f3f27722b01ff92d0dcbaba7910613542a1a7 > > Diff: https://reviews.apache.org/r/38527/diff/ > > > Testing > ------- > > # In CentOS 6.6 > sudo ./bin/mesos-tests.sh --gtest_filter="UserCgroupIsolatorTest*" --verbose > > > Thanks, > > haosdent huang > >