----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39056/#review101674 -----------------------------------------------------------
src/common/resources.cpp (line 870) <https://reviews.apache.org/r/39056/#comment159127> This change should also be applied to Resources::apply() in src/v1/resources.cpp src/common/resources.cpp (line 871) <https://reviews.apache.org/r/39056/#comment159132> Capitalize "check"; also, maybe include a brief explanation of why we might see some error in the floating point calculation. src/common/resources.cpp (line 872) <https://reviews.apache.org/r/39056/#comment159129> Should be "constexpr", maybe "static" too. src/tests/reservation_tests.cpp (line 175) <https://reviews.apache.org/r/39056/#comment159131> I think the comment here should explain why using a double value is relevant. src/tests/reservation_tests.cpp (line 245) <https://reviews.apache.org/r/39056/#comment159128> Whitespace/capitalization. - Neil Conway On Oct. 6, 2015, 5:59 p.m., Mandeep Chadha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39056/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2015, 5:59 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3552 > https://issues.apache.org/jira/browse/MESOS-3552 > > > Repository: mesos > > > Description > ------- > > Check failed due to double comparison : MESOS-3552. > > > Diffs > ----- > > src/common/resources.cpp 601388c35a1bff37c58e753d1870d53b8d0af2d1 > src/tests/reservation_tests.cpp 6b7c43c8b5c64618249dbee926383242320c111e > > Diff: https://reviews.apache.org/r/39056/diff/ > > > Testing > ------- > > Added unit test. > make check successful. > > > Thanks, > > Mandeep Chadha > >
