----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39005/ -----------------------------------------------------------
(Updated Oct. 8, 2015, 2:29 p.m.) Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. Changes ------- Provided an implementation that can work with both a XSI and GLIBC flavor of strerror_r. Use a different implementation strategy now where the buffer isn't dynamically grown but instead a "large enough" buffer is used. Also rename the function to os::strerror and put it in an independent header so it can be included by very basic infrastructure headers like `stout/error.hpp`. Bugs: MESOS-3551 https://issues.apache.org/jira/browse/MESOS-3551 Repository: mesos Description ------- This adds a thread-safe wrapper around strerror_r which has semantics similar to strerror. We plan to use this at call sites currently relying on strerror. Diffs (updated) ----- 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp e6d36ec1bf414b52d0899f0edf83e0ad8910dd0e Diff: https://reviews.apache.org/r/39005/diff/ Testing ------- make check Thanks, Benjamin Bannier