> On Oct. 8, 2015, 5:24 p.m., James Peach wrote: > > You should also rename ```benchmarks``` and ```ssl-client```. > > Kapil Arya wrote: > Good suggestion. But I think, it will be better to do that in a separate > RR (just to keep this RR chain strictly relevant for `make tests`). > > James Peach wrote: > It will take longer to file the tickets and reviews than to just make the > change now :)
I think it's not about longer or shorter. I am more concerned about this RR chain being a build-only change vs. something that touches other files, etc. :). - Kapil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39138/#review101957 ----------------------------------------------------------- On Oct. 8, 2015, 3:28 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39138/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 3:28 p.m.) > > > Review request for mesos, James Peach and Joris Van Remoortere. > > > Bugs: MESOS-3584 > https://issues.apache.org/jira/browse/MESOS-3584 > > > Repository: mesos > > > Description > ------- > > See summary > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 > > Diff: https://reviews.apache.org/r/39138/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
