----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39154/#review102002 -----------------------------------------------------------
3rdparty/libprocess/src/poll_socket.cpp (line 31) <https://reviews.apache.org/r/39154/#comment159523> Would help me to understand why `anonymous` is necessary here? 3rdparty/libprocess/src/poll_socket.cpp (line 32) <https://reviews.apache.org/r/39154/#comment159525> Personally, `stringify_` maybe better. 3rdparty/libprocess/src/poll_socket.cpp (line 113) <https://reviews.apache.org/r/39154/#comment159528> `Socket` has the following API, is it OK to use to get address? Try<Address> address() const { return impl->address(); } 3rdparty/libprocess/src/poll_socket.cpp (line 167) <https://reviews.apache.org/r/39154/#comment159524> s/.// 3rdparty/libprocess/src/poll_socket.cpp (line 178) <https://reviews.apache.org/r/39154/#comment159527> s/failed/ failed/ 3rdparty/libprocess/src/poll_socket.cpp (line 206) <https://reviews.apache.org/r/39154/#comment159526> s/failed/ failed/ 3rdparty/libprocess/src/poll_socket.cpp (line 218) <https://reviews.apache.org/r/39154/#comment159529> Can we pass `this` as parameter? So all info are there in `socket_send_data`; I'd like to leave this to your shepherd. - Klaus Ma On Oct. 9, 2015, 1:42 a.m., Brice Arnould wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39154/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 1:42 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-1661 > https://issues.apache.org/jira/browse/MESOS-1661 > > > Repository: mesos > > > Description > ------- > > Log IP addresses together with failure messages. > > > Diffs > ----- > > 3rdparty/libprocess/src/poll_socket.cpp > 28ed102972a9d8f88048aea4046ed837b6a25b35 > > Diff: https://reviews.apache.org/r/39154/diff/ > > > Testing > ------- > > Ran "make check" > > > Thanks, > > Brice Arnould > >
